Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1035 #1093

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Fix #1035 #1093

merged 4 commits into from
Apr 27, 2023

Conversation

patrickarlt
Copy link
Contributor

Address #1035 by adding proper parsing for the generate token endpoint https://developers.arcgis.com/rest/services-reference/enterprise/generate-token.htm

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1093 (cfacd71) into main (b754ab8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1093   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines         2926      2929    +3     
  Branches       527       528    +1     
=========================================
+ Hits          2926      2929    +3     
Impacted Files Coverage Δ
packages/arcgis-rest-request/src/fetch-token.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gavinr gavinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickarlt patrickarlt merged commit c0ff7a3 into main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants